-
Notifications
You must be signed in to change notification settings - Fork 445
@W-19831625: Add UAT support to TSC JWT Login #1671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@W-19831625: Add UAT support to TSC JWT Login #1671
Conversation
|
Thanks for the contribution! It looks like @BereketBirbo is an internal user so signing the CLA is not required. However, we need to confirm this. |
|
Close and reopen to see if it clears the CLA issue. |
|
@BereketBirbo please update your PR to fix the Black formatting issues (docs here: https://tableau.github.io/server-client-python/docs/dev-guide#code-and-commit) |
|
@bcantoni I have fixed the black formatting issues. Thank you |
| def __init__( | ||
| self, | ||
| jwt: str, | ||
| isUat: Optional[bool] = False, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is None a valid value for isUat? Optional indicates that it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is, but I just pushed another version making isUat just True or False as that is more clear
bcantoni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good - thanks @BereketBirbo for the changes
|
Corresponding doc changes: #1718 |
* feat: New APIs: Update multiple connections in a single workbook/datasource (#1638) * feat: enable toggling attribute capture for a site (#1619) * feat: support OIDC endpoints (#1630) * feat: add WebAuthoringForFlows capability to Permission class (#1642) * feat: support collections in favorites (#1647) * feat: Add UAT (unified access token) support to JWT login (#1671) * feat: Update permissions_item.py --added ExtractRefresh attribute (#1617) (#1669) * feat: make refresh consistent between endpoints (#1665) * feat: make ResourceReference hashable (#1668) Closes #1666 * feat: delete view (#1712) * feat: batch create schedule (#1714) * feat: users csv import (#1409) * feat: implement users bulk_remove * feat: enable idp_configuration_id in bulk_add * feat: support extensions api (#1672) * feat: Add support for receiving "Customized Monthly" schedule intervals (#1670) * feat: implement #816: project.get_by_id (#1736) * fix: put special fields first (#1622) Closes #1620 * fix: virtual connections username (#1628) Closes #1626 * fix: add contentType to tags batch actions (#1643) * fix: datasource owner/project missing parsing (#1700) * fix: datasource description update and publish (#1682) * fix: windows decoding error * fix: assert on warning instead of ignore * fix: add workbook and view setter for custom view (#1730) * fix: handle parameters for view filters (#1633) * fix: handle parameters for view filters Closes #1632
added UAT (unified access token/ tableau cloud unified jwt) support for TSC JWT login